EDSC-3951: Update GraphQL queries to use new params parameter objects
#1706
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1706 +/- ##
=======================================
Coverage 91.96% 91.96%
=======================================
Files 725 725
Lines 19395 19395
Branches 4574 4575 +1
=======================================
Hits 17837 17837
Misses 1422 1422
Partials 136 136 ☔ View full report in Codecov by Sentry. |
| @@ -350,12 +340,15 @@ export const getProjectCollections = () => async (dispatch, getState) => { | |||
| }` | |||
|
|
|||
| const response = graphQlRequestObject.search(graphQuery, { | |||
| ids: filteredIds, | |||
| includeTags: defaultCmrSearchTags.join(','), | |||
| includeGranuleCounts, | |||
There was a problem hiding this comment.
I don't think this was being used in graphql so I agree it seems fine to remove
| limit: $limit, | ||
| cursor: $cursor | ||
| ) { | ||
| query SearchCollections($params: CollectionsInput) { |
There was a problem hiding this comment.
this function might be OBE I don't see any way to access it on the controller and its not called anywhere else
| temporal: $temporal | ||
| twoDCoordinateSystem: $twoDCoordinateSystem | ||
| ) { | ||
| query GetGranuleLinks( $params: GranulesInput ) { |
There was a problem hiding this comment.
I am seeing an issue on this one where we can't get the granule downloads due to this causing a 500 error. To replicate: Find a collection add some granules to project use the Download option. Normally we get the granules links on the results page but, its erroring out
There was a problem hiding this comment.
I added a commit that seems to fix the issue locally. We needed to wrap the request in a params object but, also there were issues calling the (prepareGranuleAccessParams(granuleParams) because the pageSize field is not defined for granules in graphql. See https://github.com/nasa/cmr-graphql/blob/main/src/types/granule.graphql
eudoroolivares2016
requested review from
trevorlang and
daniel-zamora
and removed request for
eudoroolivares2016
Overview
What is the feature?
Updated some lingering graphQL requests to use the
paramsattribute with supported types.What is the Solution?
Updated GraphQL queries and calls.
What areas of the application does this impact?
Impacts Project view, main search view, and focused collection view.
Testing
Reproduction steps
Attachments
None.
Checklist
SIDEBAR - SEEKING FEEDBACK